[Top] [All Lists]

Re: [PATCH 06/11] xfs: remove wrappers around b_fspriv

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 06/11] xfs: remove wrappers around b_fspriv
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 12 Jul 2011 11:02:57 +1000
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1310423589.7019.59.camel@doink>
References: <20110710204916.856267100@xxxxxxxxxxxxxxxxxxxxxx> <20110710205017.863949257@xxxxxxxxxxxxxxxxxxxxxx> <1310423589.7019.59.camel@doink>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Jul 11, 2011 at 05:33:09PM -0500, Alex Elder wrote:
> On Sun, 2011-07-10 at 16:49 -0400, Christoph Hellwig wrote:
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> I never did understand exactly why these things
> were macro-ized, but figured it must have hidden
> some sort of conditional debug or development aid
> long ago.  In any case, good riddance.

It was part of the original Linux port. Both the Irix and Linux XFS
code was converted to use these XFS_BUF macros. Hence the core XFS
code was identical on both platforms and easy to move changes from
Irix to Linux because the macros hid the differences in buffer cache

IOWs, we really don't need them anymore :)


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>