[Top] [All Lists]

Re: [PATCH 09/11] xfs: remove the dead QUOTADEBUG debug

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 09/11] xfs: remove the dead QUOTADEBUG debug
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 12 Jul 2011 10:59:27 +1000
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1310423602.7019.62.camel@doink>
References: <20110710204916.856267100@xxxxxxxxxxxxxxxxxxxxxx> <20110710205018.525481665@xxxxxxxxxxxxxxxxxxxxxx> <1310423602.7019.62.camel@doink>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Jul 11, 2011 at 05:33:22PM -0500, Alex Elder wrote:
> On Sun, 2011-07-10 at 16:49 -0400, Christoph Hellwig wrote:
> > Remove the dead hash table test rid which has been rotting away under
> > QUOTADEBUG, including some code that was compiled for normal debug
> > builds, but not actually called without QUOTADEBUG, and enable a few
> > cheap debug checks that were hidden under QUOTADEBUG for normal
> > debug builds.
> > 
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> I've never used it and I don't suppose anyone else has
> been (or will any time soon).  So I guess it might as
> well go.

I have actually used it in the past year or so, but that was only
because I changed locking and needed to verify that the QUOTADEBUG
code still worked. But if it wasn't there, i wouldn't have had to do
that, so I'm happy to see it go.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>