[Top] [All Lists]

Re: [PATCH] xfs: start periodic workers later

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: start periodic workers later
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 11 Jul 2011 17:34:35 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110711135957.GA23737@xxxxxxxxxxxxx>
References: <20110711135957.GA23737@xxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Mon, 2011-07-11 at 09:59 -0400, Christoph Hellwig wrote:
> Start the periodic sync workers only after we have finished xfs_mountfs
> and thus fully set up the filesystem structures.  Without this we can
> call into xfs_qm_sync before the quotainfo strucute is set up if the
> mount takes unusually long, and probably hit other incomplete states
> as well.
> Also clean up the xfs_fs_fill_super error path by using consistent
> label names, and removing an impossible to reach case.
> Reported-by: Arkadiusz Miskiewicz <arekm@xxxxxxxx>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>