xfs
[Top] [All Lists]

Re: [PATCH 05/11] xfs: add a proper transaction pointer to struct xfs_bu

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 05/11] xfs: add a proper transaction pointer to struct xfs_buf
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 11 Jul 2011 17:33:04 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110710205017.667546845@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110710204916.856267100@xxxxxxxxxxxxxxxxxxxxxx> <20110710205017.667546845@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Sun, 2011-07-10 at 16:49 -0400, Christoph Hellwig wrote:
> Replace the typeless b_fspriv2 and the ugly macros around it with a properly
> typed transaction pointer.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

So it looks like you do two things.
- make it a real pointer (which it should be), when it's
  used to keep track of the transaction a buffer is
  associated with; and
- eliminate the use of this field storing cast 1's and 2's
  for verifying the way log buffers are used.

I don't see much value in the second one, and the first
is the way it should be, so this looks good to me.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>