xfs
[Top] [All Lists]

Re: [PATCH 04/11] xfs: factor out xfs_da_grow_inode_int

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 04/11] xfs: factor out xfs_da_grow_inode_int
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 11 Jul 2011 01:24:06 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20110711003743.GC23038@dastard>
References: <20110710204916.856267100@xxxxxxxxxxxxxxxxxxxxxx> <20110710205017.485558926@xxxxxxxxxxxxxxxxxxxxxx> <20110711003743.GC23038@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jul 11, 2011 at 10:37:43AM +1000, Dave Chinner wrote:
> On Sun, Jul 10, 2011 at 04:49:20PM -0400, Christoph Hellwig wrote:
> > xfs_da_grow_inode and xfs_dir2_grow_inode are mostly duplicate code.  Factor
> > the meat of those two functions into a new common helper.
> 
> Hmmmm. I'm in the process of splitting xfs_dir2_grow_inode() into
> data space vs free space variants so I can play speculative
> preallocation tricks in the directory data space to reduce dataspace
> fragmentation for large directories. Combined with a rework of the
> readir readahead code, it significantly reduces IO count and seeks
> for readdir calls...
> 
> I'll probably just rebase on top of this patch, though, because I did
> notice that the two functions were very similar to begin with. ;)

Are you two variants still sharing the core code? If yes rebasing sounds
like the better idea.  If the two dir2 variants are different enough
from the da variant I'm fine with postponing this one for now.

<Prev in Thread] Current Thread [Next in Thread>