xfs
[Top] [All Lists]

Re: [PATCH 3/4] xfstests: fix brain-o in fallocate log dump

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/4] xfstests: fix brain-o in fallocate log dump
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 8 Jul 2011 14:02:52 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <1310086426-30605-4-git-send-email-david@xxxxxxxxxxxxx>
References: <1310086426-30605-1-git-send-email-david@xxxxxxxxxxxxx> <1310086426-30605-4-git-send-email-david@xxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Fri, 2011-07-08 at 10:53 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> fsx segvs when dumping fallocate log entries. Fix magic string
> array index parameters to be zero based rather than one based.
> 
> While touching log string related stuff, make the format consistent
> with read and write operations so the log dump is easier to look at
> with the human eye.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>