xfs
[Top] [All Lists]

Re: [PATCH 00/28] patch queue for Linux 3.1, V3

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 00/28] patch queue for Linux 3.1, V3
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 8 Jul 2011 08:28:52 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20110708101848.GJ1026@dastard>
References: <20110707110535.205001532@xxxxxxxxxxxxxxxxxxxxxx> <20110708101848.GJ1026@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Jul 08, 2011 at 08:18:48PM +1000, Dave Chinner wrote:
> On Thu, Jul 07, 2011 at 07:05:35AM -0400, Christoph Hellwig wrote:
> > This version addresses the review comments.  The biggest change is that
> > the byteswaps of constants are now moved into a different patch and
> > applied more broadly.
> 
> Not sure you've noticed these new warnings from the patchset
> (gcc 4.4.4-6 debian):
> 
> fs/xfs/xfs_inode.c: In function ???xfs_itruncate_data???:
> fs/xfs/xfs_inode.c:1352: warning: unused variable ???mp???
> fs/xfs/xfs_inode_item.c: In function ???xfs_inode_item_unlock???:
> fs/xfs/xfs_inode_item.c:632: warning: unused variable ???ip???
> 
> They were in the previous version, too, so they are not new to this
> iteration.

Oh, it's both variables used only in DEBUG builds.  I'll update the
series to fix it up.

<Prev in Thread] Current Thread [Next in Thread>