| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/5] xfs: remove confusing ail cursor wrapper |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Thu, 7 Jul 2011 15:33:56 -0500 |
| Cc: | <xfs@xxxxxxxxxxx> |
| In-reply-to: | <1309757260-5484-4-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1309757260-5484-1-git-send-email-david@xxxxxxxxxxxxx> <1309757260-5484-4-git-send-email-david@xxxxxxxxxxxxx> |
| Reply-to: | <aelder@xxxxxxx> |
On Mon, 2011-07-04 at 15:27 +1000, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > xfs_trans_ail_cursor_set() doesn't set the cursor to the current log > item, it sets it to the next item. There is already a function for > doing this - xfs_trans_ail_cursor_next() - and the _set function is > simply a two line wrapper. Remove it and open code the setting of > the cursor in the two locations that call it to remove the > confusion. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> Good idea. I also appreciate the comment improvement; the "returns NULL" is something I wanted to suggest while looking at the previous patch, but that section of the file wasn't in that patch. Reviewed-by: Alex Elder <aelder@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/5] xfs: use a cursor for bulk AIL insertion, Alex Elder |
|---|---|
| Next by Date: | xfs_quota: bug: traverses bind mountpoints, Paul Nienaber |
| Previous by Thread: | Re: [PATCH 3/5] xfs: remove confusing ail cursor wrapper, Christoph Hellwig |
| Next by Thread: | [PATCH 1/5] xfs: unpin stale inodes directly in IOP_COMMITTED, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |