xfs
[Top] [All Lists]

Re: [PATCH 16/27] xfs: avoid usage of struct xfs_dir2_block

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 16/27] xfs: avoid usage of struct xfs_dir2_block
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 6 Jul 2011 04:35:30 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20110706021935.GK1026@dastard>
References: <20110701094321.936534538@xxxxxxxxxxxxxxxxxxxxxx> <20110701094605.621819832@xxxxxxxxxxxxxxxxxxxxxx> <20110706021935.GK1026@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jul 06, 2011 at 12:19:35PM +1000, Dave Chinner wrote:
> Took me a moment to realise what this does - turns the byte swap
> into a compile-time operation rather than a runtime operation.
> Nice.
> 
> Perhaps we should do that same optimisation in other magic number
> checks around the place?

We should, and I should have been more consistant about it.  In fact
I probably should split it into a separate patch.

<Prev in Thread] Current Thread [Next in Thread>