xfs
[Top] [All Lists]

Re: [PATCH 15/27] xfs: cleanup the defintion of struct xfs_dir2_sf_entry

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 15/27] xfs: cleanup the defintion of struct xfs_dir2_sf_entry
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 6 Jul 2011 04:34:27 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1309923211.3381.27.camel@doink>
References: <20110701094321.936534538@xxxxxxxxxxxxxxxxxxxxxx> <20110701094605.415405585@xxxxxxxxxxxxxxxxxxxxxx> <1309923211.3381.27.camel@doink>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jul 05, 2011 at 10:33:31PM -0500, Alex Elder wrote:
> On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote:
> > Remove the inumber member which is at a variable offset after the actual
> > name, and make name a real variable sized C99 array instead of the incorrect
> > one-sized array which confuses (not only) gcc.  Based on this clean up
> > the helpers to calculate the entry size.
> > 
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Why was the inode put after then name in the
> first place?

I've wondered that, too.  But it's been long before my time.

<Prev in Thread] Current Thread [Next in Thread>