xfs
[Top] [All Lists]

Re: [PATCH 14/27] xfs: kill struct xfs_dir2_sf

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 14/27] xfs: kill struct xfs_dir2_sf
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 6 Jul 2011 04:28:35 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20110706015705.GI1026@dastard>
References: <20110701094321.936534538@xxxxxxxxxxxxxxxxxxxxxx> <20110701094605.197942925@xxxxxxxxxxxxxxxxxxxxxx> <20110706015705.GI1026@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jul 06, 2011 at 11:57:05AM +1000, Dave Chinner wrote:
> > - * fit into the literal area of the inode.
> > + * Small directories are packed as tightly as possible so as to fit into 
> > the
> > + * literal area of the inode.  They consist of a single xfs_dir2_sf_hdr 
> > header
> > + * followed by zero or more xfs_dir2_sf_entry structures.  Due the 
> > different
> > + * inode number storage sized and the variable length name filed in
>                            size                               field
> > + * the xfs_dir2_sf_entry all these structure are variable length, and the
>                                       structures
> > + * accessors in this file need to be used to iterate over them.
>                              should be

Thanks!

> > -static inline xfs_dir2_sf_entry_t *xfs_dir2_sf_firstentry(xfs_dir2_sf_t 
> > *sfp)
> > +static inline xfs_dir2_sf_entry_t 
> > *xfs_dir2_sf_firstentry(xfs_dir2_sf_hdr_t *sfp)
> 
> Probably should split this onto two lines.

I'll make sure it'll be fine in the end, not sure which patch it'll get
folded into.

<Prev in Thread] Current Thread [Next in Thread>