[Top] [All Lists]

Re: [PATCH 26/27] xfs: cleanup I/O-related buffer flags

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 26/27] xfs: cleanup I/O-related buffer flags
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 5 Jul 2011 23:09:15 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110701094607.536262104@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110701094321.936534538@xxxxxxxxxxxxxxxxxxxxxx> <20110701094607.536262104@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote:
> Remove the unused and misnamed _XBF_RUN_QUEUES flag, rename XBF_LOG_BUFFER
> to the more fitting XBF_SYNCIO, and split XBF_ORDERED into XBF_FUA and
> XBF_FLUSH to allow more fine grained control over the bio flags.  Also
> cleanup processing of the flags in _xfs_buf_ioapply to make more sense,
> and renumber the sparse flag number space to group flags by purpose.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Interesting that _XBF_RUN_QUEUES was never actually used.
The new names are much more understandable.  Looks like
READ_META and WRITE_META are now effectively gone...

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>