Re: [PATCH 24/27] xfs: clean up buffer locking helpers

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 24/27] xfs: clean up buffer locking helpers
From:	Alex Elder <aelder@xxxxxxx>
Date:	Tue, 5 Jul 2011 22:55:06 -0500
Cc:	<xfs@xxxxxxxxxxx>
In-reply-to:	<20110701094607.155544131@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20110701094321.936534538@xxxxxxxxxxxxxxxxxxxxxx> <20110701094607.155544131@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to:	<aelder@xxxxxxx>

On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote:
> Rename xfs_buf_cond_lock and reverse it's return value to fit most other
> trylock operations in the Kernel and XFS (with the exception of down_trylock,
> after which xfs_buf_cond_lock was modelled), and replace xfs_buf_lock_val
> with an xfs_buf_islocked for use in asserts, or and opencoded variant in
> tracing.  remove the XFS_BUF_* wrappers for all the locking helpers.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Nice change.  More readable.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 16/27] xfs: avoid usage of struct xfs_dir2_block, (continued) Re: [PATCH 16/27] xfs: avoid usage of struct xfs_dir2_block, Christoph Hellwig Re: [PATCH 16/27] xfs: avoid usage of struct xfs_dir2_block, Alex Elder [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncached, Christoph Hellwig Re: [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncached, Dave Chinner Re: [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncached, Alex Elder [PATCH 27/27] xfs: avoid a few disk cache flushes, Christoph Hellwig Re: [PATCH 27/27] xfs: avoid a few disk cache flushes, Dave Chinner Re: [PATCH 27/27] xfs: avoid a few disk cache flushes, Alex Elder [PATCH 24/27] xfs: clean up buffer locking helpers, Christoph Hellwig Re: [PATCH 24/27] xfs: clean up buffer locking helpers, Dave Chinner Re: [PATCH 24/27] xfs: clean up buffer locking helpers, Alex Elder <= [PATCH 26/27] xfs: cleanup I/O-related buffer flags, Christoph Hellwig Re: [PATCH 26/27] xfs: cleanup I/O-related buffer flags, Alex Elder Re: [PATCH 26/27] xfs: cleanup I/O-related buffer flags, Christoph Hellwig Re: [PATCH 26/27] xfs: cleanup I/O-related buffer flags, Dave Chinner Re: [PATCH 26/27] xfs: cleanup I/O-related buffer flags, Christoph Hellwig [PATCH 18/27] xfs: avoid usage of struct xfs_dir2_data, Christoph Hellwig Re: [PATCH 18/27] xfs: avoid usage of struct xfs_dir2_data, Dave Chinner Re: [PATCH 18/27] xfs: avoid usage of struct xfs_dir2_data, Christoph Hellwig Re: [PATCH 18/27] xfs: avoid usage of struct xfs_dir2_data, Alex Elder Re: [PATCH 18/27] xfs: avoid usage of struct xfs_dir2_data, Christoph Hellwig

Previous by Date:	Re: [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncached, Alex Elder
Next by Date:	Re: XFS internal error (memory corruption), Dave Chinner
Previous by Thread:	Re: [PATCH 24/27] xfs: clean up buffer locking helpers, Dave Chinner
Next by Thread:	[PATCH 26/27] xfs: cleanup I/O-related buffer flags, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]