xfs
[Top] [All Lists]

Re: [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncache

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncached
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 5 Jul 2011 22:57:25 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110701094607.356791525@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110701094321.936534538@xxxxxxxxxxxxxxxxxxxxxx> <20110701094607.356791525@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote:
> All other xfs_buf_get/read-like helpers return the buffer locked, make sure
> xfs_buf_get_uncached isn't different for no reason.  Half of the callers
> already lock it directly after, and the others probably should also keep
> it locked if only for consistency and beeing able to use xfs_buf_rele,
> but I'll leave that for later.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>