xfs
[Top] [All Lists]

Re: [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncache

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncached
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 6 Jul 2011 13:48:40 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110701094607.356791525@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110701094321.936534538@xxxxxxxxxxxxxxxxxxxxxx> <20110701094607.356791525@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Jul 01, 2011 at 05:43:46AM -0400, Christoph Hellwig wrote:
> All other xfs_buf_get/read-like helpers return the buffer locked, make sure
> xfs_buf_get_uncached isn't different for no reason.  Half of the callers
> already lock it directly after, and the others probably should also keep
> it locked if only for consistency and beeing able to use xfs_buf_rele,
> but I'll leave that for later.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>