xfs
[Top] [All Lists]

Re: [PATCH 20/27] xfs: cleanup the defintion of struct xfs_dir2_data_ent

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 20/27] xfs: cleanup the defintion of struct xfs_dir2_data_entry
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 5 Jul 2011 22:44:32 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110701094606.386730624@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110701094321.936534538@xxxxxxxxxxxxxxxxxxxxxx> <20110701094606.386730624@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote:
> Remove the tag member which is at a variable offset after the actual
> name, and make name a real variable sized C99 array instead of the incorrect
> one-sized array which confuses (not only) gcc.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

One comment, but looks good.

Oh, and also, fix spelling of "definition" in the subject
line here and in other patches in this series.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Index: xfs/fs/xfs/xfs_dir2_data.h
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_dir2_data.h   2011-06-29 13:42:35.521563513 +0200
> +++ xfs/fs/xfs/xfs_dir2_data.h        2011-06-29 13:43:03.284746440 +0200
> @@ -98,14 +98,14 @@ typedef struct xfs_dir2_data_hdr {
>  
>  /*
>   * Active entry in a data block.  Aligned to 8 bytes.
> - * Tag appears as the last 2 bytes.
> + *
> + * After the variable length name field there is a 2 byte tag field, which
> + * can be accessed using xfs_dir2_data_entry_tag_p.
>   */
>  typedef struct xfs_dir2_data_entry {
>       __be64                  inumber;        /* inode number */
>       __u8                    namelen;        /* name length */
> -     __u8                    name[1];        /* name bytes, no null */
> -                                             /* variable offset */
> -     __be16                  tag;            /* starting offset of us */
> +     __u8                    name[];         /* name bytes, no null */

Maybe put the comment about the tag field here, as
was done elsewhere.  (But the pictures are even
better...)

>  } xfs_dir2_data_entry_t;
>  
>  /*
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs



<Prev in Thread] Current Thread [Next in Thread>