xfs
[Top] [All Lists]

Re: [PATCH 12/27] xfs: factor out xfs_dir2_leaf_find_entry

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 12/27] xfs: factor out xfs_dir2_leaf_find_entry
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 5 Jul 2011 17:36:44 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110701094604.795668656@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110701094321.936534538@xxxxxxxxxxxxxxxxxxxxxx> <20110701094604.795668656@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote:
> plain text document attachment (xfs-factor-dir2-leaf-code)
> Add a new xfs_dir2_leaf_find_entry helper to factor out some duplicate code
> from xfs_dir2_leaf_addname xfs_dir2_leafn_add.  Found by Eric Sandeen using
> an automated code duplication checker.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Nice.

Reviewed-by: Alex Elder <aelder@xxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>