[Top] [All Lists]

Re: [PATCH 02/27] xfs: re-enable non-blocking behaviour in xfs_map_block

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 02/27] xfs: re-enable non-blocking behaviour in xfs_map_blocks
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 5 Jul 2011 17:35:19 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110701094602.465074143@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110701094321.936534538@xxxxxxxxxxxxxxxxxxxxxx> <20110701094602.465074143@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote:
> The non-blockig behaviour in xfs_map_blocks currently is conditional on
> having both the WB_SYNC_NONE sync_mode and the nonblocking flag set.
> The latter used to be used by both pdflush, kswapd and a few other places
> in older kernels, but has been fading out starting with the introduction
> of the per-bdi flusher threads.
> Enable the non-blocking behaviour for all WB_SYNC_NONE calls to get back
> the behaviour we want.

The subject line should refer to xfs_vm_writepage()
(not xfs_map_blocks()).  Unless I hear otherwise I
will plan to change that for you.

Other than that this looks OK to me.

Signed-off-by: Alex Elder <aelder@xxxxxxx>

> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>