xfs
[Top] [All Lists]

Re: [PATCH 15/27] xfs: kill struct xfs_dir2_sf

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 15/27] xfs: kill struct xfs_dir2_sf
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 30 Jun 2011 03:09:18 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20110630070449.GJ561@dastard>
References: <20110629140109.003209430@xxxxxxxxxxxxxxxxxxxxxx> <20110629140339.466443510@xxxxxxxxxxxxxxxxxxxxxx> <20110630070449.GJ561@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jun 30, 2011 at 05:04:49PM +1000, Dave Chinner wrote:
> On Wed, Jun 29, 2011 at 10:01:24AM -0400, Christoph Hellwig wrote:
> > The list field of it is never cactually used, so all uses can simply be
> > replaced with the xfs_dir2_sf_hdr_t type that it has as first member.
> > 
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> I can't help but think this would have been a much smaller patch if
> you rolled the contents of the xfs_dir2_sf_hdr_t into xfs_dir2_sf_t
> and killed the xfs_dir2_sf_hdr_t instead. There's many more
> occurrences of xfs_dir2_sf_t than there are xfs_dir2_sf_hdr_t.

It would have been simpler, but using the xfs_dir2_sf_hdr_t makes
more sense to me.  If there's broad disagreement with this (and
the similar changes for the other structures) I'll revisit the naming
scheme.

<Prev in Thread] Current Thread [Next in Thread>