Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr

To:	Alex Elder <aelder@xxxxxxx>
Subject:	Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Thu, 30 Jun 2011 03:07:02 -0400
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to:	<1309385603.8649.37.camel@doink>
References:	<20110629140109.003209430@xxxxxxxxxxxxxxxxxxxxxx> <20110629140337.876449102@xxxxxxxxxxxxxxxxxxxxxx> <1309385603.8649.37.camel@doink>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Wed, Jun 29, 2011 at 05:13:23PM -0500, Alex Elder wrote:
> How/where does iattr->ia_mtime get initialized to the current
> value (I believe it would just match iattr->ia_ctime)?

As Dave mentioned it's set by the caller.  Maybe the code is a bit
cleaner if I check for both ATTR_CTIME and ATTR_MTIME?  The add
MTIME to the mask stuff also is superflous from a quick looks as
we always have both set anyway.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 00/27] patch queue for Linux 3.1, Christoph Hellwig [PATCH 02/27] xfs: remove the unused ilock_nowait codepath in writepage, Christoph Hellwig Re: [PATCH 02/27] xfs: remove the unused ilock_nowait codepath in writepage, Dave Chinner Re: [PATCH 02/27] xfs: remove the unused ilock_nowait codepath in writepage, Dave Chinner Re: [PATCH 02/27] xfs: remove the unused ilock_nowait codepath in writepage, Christoph Hellwig [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Christoph Hellwig Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Alex Elder Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Dave Chinner Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Christoph Hellwig <= [PATCH 04/27] xfs: cleanup xfs_add_to_ioend, Christoph Hellwig Re: [PATCH 04/27] xfs: cleanup xfs_add_to_ioend, Alex Elder Re: [PATCH 04/27] xfs: cleanup xfs_add_to_ioend, Dave Chinner [PATCH 05/27] xfs: work around bogus gcc warning in xfs_allocbt_init_cursor, Christoph Hellwig Re: [PATCH 05/27] xfs: work around bogus gcc warning in xfs_allocbt_init_cursor, Alex Elder [PATCH 01/27] xfs: PF_FSTRANS should never be set in ->writepage, Christoph Hellwig Re: [PATCH 01/27] xfs: PF_FSTRANS should never be set in ->writepage, Dave Chinner [PATCH 08/27] xfs: kill xfs_itruncate_start, Christoph Hellwig Re: [PATCH 08/27] xfs: kill xfs_itruncate_start, Alex Elder [PATCH 10/27] xfs: improve sync behaviour in the fact of aggressive dirtying, Christoph Hellwig

Previous by Date:	Re: [PATCH 15/27] xfs: kill struct xfs_dir2_sf, Dave Chinner
Next by Date:	Re: [PATCH 15/27] xfs: kill struct xfs_dir2_sf, Christoph Hellwig
Previous by Thread:	Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Dave Chinner
Next by Thread:	[PATCH 04/27] xfs: cleanup xfs_add_to_ioend, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size