xfs
[Top] [All Lists]

Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 30 Jun 2011 03:07:02 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1309385603.8649.37.camel@doink>
References: <20110629140109.003209430@xxxxxxxxxxxxxxxxxxxxxx> <20110629140337.876449102@xxxxxxxxxxxxxxxxxxxxxx> <1309385603.8649.37.camel@doink>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jun 29, 2011 at 05:13:23PM -0500, Alex Elder wrote:
> How/where does iattr->ia_mtime get initialized to the current
> value (I believe it would just match iattr->ia_ctime)?

As Dave mentioned it's set by the caller.  Maybe the code is a bit
cleaner if I check for both ATTR_CTIME and ATTR_MTIME?  The add
MTIME to the mask stuff also is superflous from a quick looks as
we always have both set anyway.

<Prev in Thread] Current Thread [Next in Thread>