Re: [PATCH 08/27] xfs: kill xfs_itruncate

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 08/27] xfs: kill xfs_itruncate_start
From:	Alex Elder <aelder@xxxxxxx>
Date:	Wed, 29 Jun 2011 17:13:32 -0500
Cc:	<xfs@xxxxxxxxxxx>
In-reply-to:	<20110629140338.098991196@xxxxxxxxxxxxxxxxxxxxxx>
References:	<20110629140109.003209430@xxxxxxxxxxxxxxxxxxxxxx> <20110629140338.098991196@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to:	<aelder@xxxxxxx>

On Wed, 2011-06-29 at 10:01 -0400, Christoph Hellwig wrote:
> plain text document attachment (xfs-kill-xfs_itruncate_start)
> xfs_itruncate_start is a rather length wrapper that evaluates to a call
> to xfs_ioend_wait and xfs_tosspages, and only has two callers.
> 
> Instead of using the complicated checks left over from IRIX where we
> can to truncate the pagecache just call xfs_tosspages
> (aka truncate_inode_pages) directly as we want to get rid of all data
> after i_size, and truncate_inode_pages handles incorrect alignments
> and too large offsets just fine.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Nice cleanup.  Looks good.

I will continue reviewing this series tomorrow.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, (continued) Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Dave Chinner Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Christoph Hellwig [PATCH 04/27] xfs: cleanup xfs_add_to_ioend, Christoph Hellwig Re: [PATCH 04/27] xfs: cleanup xfs_add_to_ioend, Alex Elder Re: [PATCH 04/27] xfs: cleanup xfs_add_to_ioend, Dave Chinner [PATCH 05/27] xfs: work around bogus gcc warning in xfs_allocbt_init_cursor, Christoph Hellwig Re: [PATCH 05/27] xfs: work around bogus gcc warning in xfs_allocbt_init_cursor, Alex Elder [PATCH 01/27] xfs: PF_FSTRANS should never be set in ->writepage, Christoph Hellwig Re: [PATCH 01/27] xfs: PF_FSTRANS should never be set in ->writepage, Dave Chinner [PATCH 08/27] xfs: kill xfs_itruncate_start, Christoph Hellwig Re: [PATCH 08/27] xfs: kill xfs_itruncate_start, Alex Elder <= [PATCH 10/27] xfs: improve sync behaviour in the fact of aggressive dirtying, Christoph Hellwig Re: [PATCH 10/27] xfs: improve sync behaviour in the fact of aggressive dirtying, Dave Chinner [PATCH 03/27] xfs: use write_cache_pages for writeback clustering, Christoph Hellwig Re: [PATCH 03/27] xfs: use write_cache_pages for writeback clustering, Dave Chinner Re: [PATCH 03/27] xfs: use write_cache_pages for writeback clustering, Dave Chinner Re: [PATCH 03/27] xfs: use write_cache_pages for writeback clustering, Christoph Hellwig Re: [PATCH 03/27] xfs: use write_cache_pages for writeback clustering, Dave Chinner Re: [PATCH 03/27] xfs: use write_cache_pages for writeback clustering, Dave Chinner [PATCH 11/27] xfs: fix filesystsem freeze race in xfs_trans_alloc, Christoph Hellwig Re: [PATCH 11/27] xfs: fix filesystsem freeze race in xfs_trans_alloc, Dave Chinner

Previous by Date:	Re: [PATCH 07/27] xfs: always log timestamp updates in xfs_setattr_size, Alex Elder
Next by Date:	Re: long hangs when deleting large directories (3.0-rc3), Dave Chinner
Previous by Thread:	[PATCH 08/27] xfs: kill xfs_itruncate_start, Christoph Hellwig
Next by Thread:	[PATCH 10/27] xfs: improve sync behaviour in the fact of aggressive dirtying, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 08/27] xfs: kill xfs_itruncate_start