xfs
[Top] [All Lists]

Re: [PATCH] xfs: replace bp->flags usage with predefined macros

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: replace bp->flags usage with predefined macros
From: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Date: Wed, 29 Jun 2011 13:33:43 -0700
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, Alex Elder <aelder@xxxxxxx>, XFS Mailing List <xfs@xxxxxxxxxxx>
In-reply-to: <20110629063001.GA12554@xxxxxxxxxxxxx>
Organization: IBM
References: <1309308784.5505.6214.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20110629044616.GB1026@dastard> <20110629063001.GA12554@xxxxxxxxxxxxx>
Reply-to: sekharan@xxxxxxxxxx
On Wed, 2011-06-29 at 02:30 -0400, Christoph Hellwig wrote:
> On Wed, Jun 29, 2011 at 02:46:16PM +1000, Dave Chinner wrote:
> > On Tue, Jun 28, 2011 at 05:53:04PM -0700, Chandra Seetharaman wrote:
> > > Cleanup: Replace bp->flags usage with predefined macros.
> > > 
> > > Signed-off-by: Chandra Seetharaman <sekharan@xxxxxxxxxx>
> > 
> > Christoph can correct me if I'm wrong, but I'm pretty sure his long term
> > direction is to remove the XFS_BUF_* macros completely.
> 
> Yes, at least those that are simpler flags get/set/clear wrappers.

So, the suggestion is to go the other way and remove all the wrappers
and use bp->flags directly ?
> 


<Prev in Thread] Current Thread [Next in Thread>