xfs
[Top] [All Lists]

Re: [PATCH] xfs_repair: Check if agno is inside the filesystem

To: Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH] xfs_repair: Check if agno is inside the filesystem
From: Lukas Czerner <lczerner@xxxxxxxxxx>
Date: Tue, 28 Jun 2011 13:14:33 +0200 (CEST)
Cc: xfs@xxxxxxxxxxx, aelder@xxxxxxx, david@xxxxxxxxxxxxx
In-reply-to: <1309255279-15608-1-git-send-email-lczerner@xxxxxxxxxx>
References: <1309255279-15608-1-git-send-email-lczerner@xxxxxxxxxx>
User-agent: Alpine 2.00 (LFD 1167 2008-08-23)
On Tue, 28 Jun 2011, Lukas Czerner wrote:

> When getting an inode tree pointer from an array inode_tree_ptrs, we
> should check if agno, which is used as a pointer to the array, lives
> within the file system, because if it is not, we can end up touching
> uninitialized memory.
> 
> This commit fixes it by passing xfs_mount to affected functions and
> checking if agno really is inside the file system.
> 
> This solves Red Hat bug #694706
> 
> Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

I forgot to mention a version of the patch. This is version 2.

Thanks!
-Lukas

<Prev in Thread] Current Thread [Next in Thread>