[Top] [All Lists]

Re: [PATCH] xfsprogs: don't hard code the shell binary

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: don't hard code the shell binary
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 28 Jun 2011 03:41:37 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1309245348-12638-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1309245348-12638-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Jun 28, 2011 at 05:15:48PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> Recent changes to debian unstable user space have caused the
> xfsprogs build to break as certain shell functionality is being
> assumed by libtool and friends.  The configure scripts test and
> select the correct shell, but the input files ignore this and hard
> code the shell to use and hence now break.
> Fix this by using the shell that the configure scripts decide is the
> right one to use.

Looks good.  The same fix should also be applied to xfsdump, xfstests
and dmapi.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>