[Top] [All Lists]

Re: [PATCH 1/3 v2] XFS TESTS: Fix 252 Failure: Relax fiemap filter

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/3 v2] XFS TESTS: Fix 252 Failure: Relax fiemap filter
From: Allison Henderson <achender@xxxxxxxxxxxxxxxxxx>
Date: Mon, 27 Jun 2011 22:17:12 -0700
Cc: xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx
In-reply-to: <20110628045903.GK32466@dastard>
References: <1309235247-32650-1-git-send-email-achender@xxxxxxxxxxxxxxxxxx> <1309235247-32650-2-git-send-email-achender@xxxxxxxxxxxxxxxxxx> <20110628045903.GK32466@dastard>
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20110414 Thunderbird/3.1.10
On 06/27/2011 09:59 PM, Dave Chinner wrote:
On Mon, Jun 27, 2011 at 09:27:25PM -0700, Allison Henderson wrote:
I seriously dislike conditional parameter passing in shell scripts
at the best of times, but for filter functions I really think it is
the wrong thing to do. It significantly obfuscates the working of
the function for no really good reason.

Just write a new filter function, and factor out the common parts of
them if the amount of code duplication is sufficient to make it
desirable to do so.

Ok, it doesn't look like a lot of code, I can separate them into their
own functions.

+       md5sum $testfile | cut -d ' ' -f1

Why cut out the file name? It's not like it changes at all....

Oh, it looked like there's a pid attached to the file name, so I thought I should remove that from the output

Allison Henderson

<Prev in Thread] Current Thread [Next in Thread>