xfs
[Top] [All Lists]

Re: [PATCH] xfs_repair: Check if agno is inside the filesystem

To: Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH] xfs_repair: Check if agno is inside the filesystem
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 28 Jun 2011 11:28:38 +1000
Cc: xfs@xxxxxxxxxxx, aelder@xxxxxxx
In-reply-to: <1309193610-17078-1-git-send-email-lczerner@xxxxxxxxxx>
References: <1309193610-17078-1-git-send-email-lczerner@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Jun 27, 2011 at 06:53:30PM +0200, Lukas Czerner wrote:
> When getting an inode tree pointer from an array inode_tree_ptrs, we
> should check if agno, which is used as a pointer to the array, lives
> within the file system, because if it is not, we can end up touching
> uninitialized memory.

How do you get an agno outside the bounds of the filesystem?

> This commit fixes it by passing xfs_mount_t to affected functions and
> checking if agno really is inside the file system.

We're slowly removing typedefs as we change code. So probably better
to use struct xfs_mount for all the places where you add an
xfs_mount_t.

Otherwise seems fine.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>