xfs
[Top] [All Lists]

Re: duplicate code in dir2

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: duplicate code in dir2
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 23 Jun 2011 07:03:18 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4E020977.9080000@xxxxxxxxxxx>
References: <4E020912.9020106@xxxxxxxxxxx> <4E020977.9080000@xxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jun 22, 2011 at 10:25:43AM -0500, Eric Sandeen wrote:
> Another interesting chunk elsewhere:
> 
> /src/git/linux-2.6/fs/xfs/xfs_da_btree.c(782)
> /src/git/linux-2.6/fs/xfs/xfs_attr_leaf.c(1542)
>                 *action = 0;
>                 return(0);
>         if (count == 0) {

The da_btree code is a big mess with things duplicated all over.
There's a third copy of this in the dir2 code as well.  I have started
consolidating some of this code a while ago in prepation of adding
checksumming to the dir and attr code, but it has bit rotted a bit since
and I've not managed to get back to it.

<Prev in Thread] Current Thread [Next in Thread>