[Top] [All Lists]

Re: [PATCH 02/12] vmscan: shrinker->nr updates race and go wrong

To: david@xxxxxxxxxxxxx
Subject: Re: [PATCH 02/12] vmscan: shrinker->nr updates race and go wrong
From: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
Date: Mon, 20 Jun 2011 13:30:29 +0900
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20110620012531.GN561@dastard>
References: <1306998067-27659-1-git-send-email-david@xxxxxxxxxxxxx> <1306998067-27659-3-git-send-email-david@xxxxxxxxxxxxx> <4DFE987E.1070900@xxxxxxxxxxxxxx> <20110620012531.GN561@dastard>
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv: Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10
>> Looks great fix. Please remove tracepoint change from this patch and send it
>> to -stable. iow, I expect I'll ack your next spin.
> I don't believe such a change belongs in -stable. This code has been
> buggy for many years and as I mentioned it actually makes existing
> bad shrinker behaviour worse. I don't test stable kernels, so I've
> got no idea what side effects it will have outside of this series.
> I'm extremely hesitant to change VM behaviour in stable kernels
> without having tested first, so I'm not going to push it for stable
> kernels.

Ok, I have no strong opinion.

> If you want it in stable kernels, then you can always let
> stable@xxxxxxxxxx know once the commits are in the mainline tree and
> you've tested them...

<Prev in Thread] Current Thread [Next in Thread>