xfs
[Top] [All Lists]

Re: [PATCH 01/12] vmscan: add shrink_slab tracepoints

To: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
Subject: Re: [PATCH 01/12] vmscan: add shrink_slab tracepoints
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 20 Jun 2011 10:53:21 +1000
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <4DFE97F1.2030206@xxxxxxxxxxxxxx>
References: <1306998067-27659-1-git-send-email-david@xxxxxxxxxxxxx> <1306998067-27659-2-git-send-email-david@xxxxxxxxxxxxx> <4DFE97F1.2030206@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Jun 20, 2011 at 09:44:33AM +0900, KOSAKI Motohiro wrote:
> (2011/06/02 16:00), Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > Іt is impossible to understand what the shrinkers are actually doing
> > without instrumenting the code, so add a some tracepoints to allow
> > insight to be gained.
> > 
> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> > ---
> >  include/trace/events/vmscan.h |   67 
> > +++++++++++++++++++++++++++++++++++++++++
> >  mm/vmscan.c                   |    6 +++-
> >  2 files changed, 72 insertions(+), 1 deletions(-)
> 
> This look good to me. I have two minor request. 1) please change patch order,
> move this patch after shrinker changes. iow, now both this and [2/12] have
> tracepoint change. I don't like it.

No big deal - I'll just fold the second change (how shrinker->nr is
passed into the tracepoint) into the first. Tracepoints should be
first in the series, anyway, otherwise there is no way to validate
the before/after effect of the bug fixes....

> 2) please avoid cryptic abbreviated variable
> names. Instead, please just use the same variable name with
> vmscan.c source code.

So replace cryptic abbreviated names with slightly different
cryptic abbreviated names? ;)

Sure, I can do that...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>