[Top] [All Lists]

Re: [PATCH 3/3 v5] XFS TESTS: Add ENOSPC Hole Punch Test

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3 v5] XFS TESTS: Add ENOSPC Hole Punch Test
From: Allison Henderson <achender@xxxxxxxxxxxxxxxxxx>
Date: Fri, 17 Jun 2011 13:20:15 -0700
Cc: Allison Henderson <achender@xxxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20110617120838.GA20714@xxxxxxxxxxxxx>
References: <4DED6405.7020104@xxxxxxxxxxxx> <20110617120838.GA20714@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20110414 Thunderbird/3.1.10
On 06/17/2011 05:08 AM, Christoph Hellwig wrote:
This one fails for me because my test system doesn't have sudo
installed.  I can't see any reason why a simple su wouldn't be enough.

We already have a helper to make su usable on both IRIX and Linux in
test 123, and it might be a good idea to add this to the common routines
and use it.

I'd also suggest to split this test off 252 into a new test case, as
unlike the other tests it actually requires a scratch devices, and in
general is pretty different from the simple xfs_io exercises in 252.

I'd also move the newly added helpers directly into the new testcase
as they really aren't common.

Hi Christoph,

Thanks for the review, I will make those adjustments then and submit them in a separate patch set since it sounds like 1/3 and 2/3 are moving forward. Thanks again! :)

Allison Henderson

<Prev in Thread] Current Thread [Next in Thread>