xfs
[Top] [All Lists]

Re: [PATCH 3/3 v5] XFS TESTS: Add ENOSPC Hole Punch Test

To: Allison Henderson <achender@xxxxxxxxxxxx>
Subject: Re: [PATCH 3/3 v5] XFS TESTS: Add ENOSPC Hole Punch Test
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 17 Jun 2011 08:08:38 -0400
Cc: linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4DED6405.7020104@xxxxxxxxxxxx>
References: <4DED6405.7020104@xxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
This one fails for me because my test system doesn't have sudo
installed.  I can't see any reason why a simple su wouldn't be enough.

We already have a helper to make su usable on both IRIX and Linux in
test 123, and it might be a good idea to add this to the common routines
and use it.

I'd also suggest to split this test off 252 into a new test case, as
unlike the other tests it actually requires a scratch devices, and in
general is pretty different from the simple xfs_io exercises in 252.

I'd also move the newly added helpers directly into the new testcase
as they really aren't common.

<Prev in Thread] Current Thread [Next in Thread>