| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v2] xfs: make log devices with write back caches work |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Thu, 16 Jun 2011 11:32:54 -0500 |
| Cc: | <xfs@xxxxxxxxxxx> |
| In-reply-to: | <20110616120223.GA9854@xxxxxxxxxxxxx> |
| References: | <20110616120223.GA9854@xxxxxxxxxxxxx> |
| Reply-to: | <aelder@xxxxxxx> |
On Thu, 2011-06-16 at 08:02 -0400, Christoph Hellwig wrote: > There's no reason not to support cache flushing on external log devices. > The only thing this really requires is flushing the data device first > both in fsync and log commits. A side effect is that we also have to > remove the barrier write test during mount, which has been superflous > since the new FLUSH+FUA code anyway. Also use the chance to flush the > RT subvolume write cache before the fsync commit, which is required > for correct semantics. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Thanks for the explanations and update. This looks good. I'm testing now and barring a problem should be to Linus this weekend. Reviewed-by: Alex Elder <aelder@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: xfstests test case 032 fails for wrong reason, Chandra Seetharaman |
|---|---|
| Next by Date: | Re: xfstests test case 032 fails for wrong reason, Eric Sandeen |
| Previous by Thread: | [PATCH v2] xfs: make log devices with write back caches work, Christoph Hellwig |
| Next by Thread: | sparse file handling bug in XFS, Sean Noonan |
| Indexes: | [Date] [Thread] [Top] [All Lists] |