xfs
[Top] [All Lists]

PATCH: remove varibale that serve no purpose in xfs_alloc_ag_vextent_exa

To: xfs@xxxxxxxxxxx
Subject: PATCH: remove varibale that serve no purpose in xfs_alloc_ag_vextent_exact()
From: Chandra Seetharaman <sekharan@xxxxxxxxxx>
Date: Thu, 09 Jun 2011 09:47:49 -0700
Cc: Alex Elder <aelder@xxxxxxx>
Organization: IBM
Reply-to: sekharan@xxxxxxxxxx
Hi,

As per Alex Elder suggestion, here is a patch to remove non-purpose
variables in xfs_alloc_ag_vextent_exact()

chandra

--------------------
Remove the variables that serves no purpose.

Signed-off-by: Chandra Seetharaman <sekharan@xxxxxxxxxx>
---
diff --git a/fs/xfs/xfs_alloc.c b/fs/xfs/xfs_alloc.c
index 95862bb..7a53c8f 100644
--- a/fs/xfs/xfs_alloc.c
+++ b/fs/xfs/xfs_alloc.c
@@ -570,9 +570,7 @@ xfs_alloc_ag_vextent_exact(
        xfs_agblock_t   tbno;   /* start block of trimmed extent */
        xfs_extlen_t    tlen;   /* length of trimmed extent */
        xfs_agblock_t   tend;   /* end block of trimmed extent */
-       xfs_agblock_t   end;    /* end of allocated extent */
        int             i;      /* success/failure of operation */
-       xfs_extlen_t    rlen;   /* length of returned extent */
 
        ASSERT(args->alignment == 1);
 
@@ -625,18 +623,16 @@ xfs_alloc_ag_vextent_exact(
         *
         * Fix the length according to mod and prod if given.
         */
-       end = XFS_AGBLOCK_MIN(tend, args->agbno + args->maxlen);
-       args->len = end - args->agbno;
+       args->len = XFS_AGBLOCK_MIN(tend, args->agbno + args->maxlen)
+                                               - args->agbno;
        xfs_alloc_fix_len(args);
        if (!xfs_alloc_fix_minleft(args))
                goto not_found;
 
-       rlen = args->len;
-       ASSERT(args->agbno + rlen <= tend);
-       end = args->agbno + rlen;
+       ASSERT(args->agbno + args->len <= tend);
 
        /*
-        * We are allocating agbno for rlen [agbno .. end]
+        * We are allocating agbno for args->len
         * Allocate/initialize a cursor for the by-size btree.
         */
        cnt_cur = xfs_allocbt_init_cursor(args->mp, args->tp, args->agbp,
---

<Prev in Thread] Current Thread [Next in Thread>
  • PATCH: remove varibale that serve no purpose in xfs_alloc_ag_vextent_exact(), Chandra Seetharaman <=