Re: [PATCH 08/12] superblock: introduce per-sb cache shrinker infrastruc

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 08/12] superblock: introduce per-sb cache shrinker infrastructure
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Sat, 4 Jun 2011 10:08:48 -0400
Cc:	Al Viro <viro@xxxxxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to:	<20110604015212.GD561@dastard>
References:	<1306998067-27659-1-git-send-email-david@xxxxxxxxxxxxx> <1306998067-27659-9-git-send-email-david@xxxxxxxxxxxxx> <20110604004231.GV11521@xxxxxxxxxxxxxxxxxx> <20110604015212.GD561@dastard>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Sat, Jun 04, 2011 at 11:52:12AM +1000, Dave Chinner wrote:
> I wanted to put it early on in the unmount path so that the shrinker
> was guaranteed to be gone before evict_inodes() was called. That
> would mean that it is obviously safe to remove the iprune_sem
> serialisation in that function.

The iprune_sem removal is fine as soon as you have a per-sb shrinker
for the inodes which keeps an active reference on the superblock until
all the inodes are evicted.

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 03/12] vmscan: reduce wind up shrinker->nr when shrinker can't do work, (continued) Re: [PATCH 03/12] vmscan: reduce wind up shrinker->nr when shrinker can't do work, KOSAKI Motohiro [PATCH 04/12] vmscan: add customisable shrinker batch size, Dave Chinner [PATCH 11/12] vfs: increase shrinker batch size, Dave Chinner Re: [PATCH 11/12] vfs: increase shrinker batch size, Nicolas Kaiser [PATCH 07/12] inode: move to per-sb LRU locks, Dave Chinner [PATCH 09/12] inode: remove iprune_sem, Dave Chinner [PATCH 10/12] superblock: add filesystem shrinker operations, Dave Chinner [PATCH 08/12] superblock: introduce per-sb cache shrinker infrastructure, Dave Chinner Re: [PATCH 08/12] superblock: introduce per-sb cache shrinker infrastructure, Al Viro Re: [PATCH 08/12] superblock: introduce per-sb cache shrinker infrastructure, Dave Chinner Re: [PATCH 08/12] superblock: introduce per-sb cache shrinker infrastructure, Christoph Hellwig <= Re: [PATCH 08/12] superblock: introduce per-sb cache shrinker infrastructure, Al Viro Re: [PATCH 08/12] superblock: introduce per-sb cache shrinker infrastructure, Al Viro [PATCH 12/12] xfs: make use of new shrinker callout for the inode cache, Dave Chinner Re: [PATCH 0/12] Per superblock cache reclaim, Christoph Hellwig Re: [PATCH 0/12] Per superblock cache reclaim, KOSAKI Motohiro

Previous by Date:	Re: I/O hang, possibly XFS, possibly general, Stan Hoeppner
Next by Date:	Re: [PATCH 08/12] superblock: introduce per-sb cache shrinker infrastructure, Al Viro
Previous by Thread:	Re: [PATCH 08/12] superblock: introduce per-sb cache shrinker infrastructure, Dave Chinner
Next by Thread:	Re: [PATCH 08/12] superblock: introduce per-sb cache shrinker infrastructure, Al Viro
Indexes:	[Date] [Thread] [Top] [All Lists]