xfs
[Top] [All Lists]

Re: [PATCH 08/12] superblock: introduce per-sb cache shrinker infrastruc

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 08/12] superblock: introduce per-sb cache shrinker infrastructure
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 4 Jun 2011 10:08:48 -0400
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <20110604015212.GD561@dastard>
References: <1306998067-27659-1-git-send-email-david@xxxxxxxxxxxxx> <1306998067-27659-9-git-send-email-david@xxxxxxxxxxxxx> <20110604004231.GV11521@xxxxxxxxxxxxxxxxxx> <20110604015212.GD561@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Jun 04, 2011 at 11:52:12AM +1000, Dave Chinner wrote:
> I wanted to put it early on in the unmount path so that the shrinker
> was guaranteed to be gone before evict_inodes() was called. That
> would mean that it is obviously safe to remove the iprune_sem
> serialisation in that function.

The iprune_sem removal is fine as soon as you have a per-sb shrinker
for the inodes which keeps an active reference on the superblock until
all the inodes are evicted.

<Prev in Thread] Current Thread [Next in Thread>