xfs
[Top] [All Lists]

Re: [PATCH 11/12] vfs: increase shrinker batch size

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 11/12] vfs: increase shrinker batch size
From: Nicolas Kaiser <nikai@xxxxxxxxx>
Date: Thu, 2 Jun 2011 11:30:26 +0200
Cc: linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, xfs@xxxxxxxxxxx
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAQMAAABtzGvEAAAAAXNSR0IArs4c6QAAAAZQTFRF AJnV/f/88sgWwwAAAKNJREFUGNM10LENwyAQheFHKCgZgTVSRHI2gy5reROTDSiREvnyHhdXnwXS+ T+ACJgBYTiGSmDDOTdR7XDeTi9ksxEcoKFcTOCJLO7kC5SWFjPZCR69nI9+x5u6OJM1RN5UYUiNKa ZRpHHUoqh1v8hKEZ1FSGCrYOvgVmxd9DIXcSJwLTycm7bj0e4wkJGB48w/FckAwUKl/OGDZAcqItk BU+wHXLqKsjYyPeMAAAAASUVORK5CYII=
In-reply-to: <1306998067-27659-12-git-send-email-david@xxxxxxxxxxxxx>
Organization: -
References: <1306998067-27659-1-git-send-email-david@xxxxxxxxxxxxx> <1306998067-27659-12-git-send-email-david@xxxxxxxxxxxxx>
Just noticed below two typos.

* Dave Chinner <david@xxxxxxxxxxxxx>:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Now that the per-sb shrinker is responsible for shrinking 2 or more
> caches, increase the batch size to keep econmies of scale for

economies

(..)

>  Documentation/filesystems/vfs.txt |    5 +++++
>  fs/super.c                        |    1 +
>  2 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/filesystems/vfs.txt 
> b/Documentation/filesystems/vfs.txt
> index dc732d2..2e26973 100644
> --- a/Documentation/filesystems/vfs.txt
> +++ b/Documentation/filesystems/vfs.txt
> @@ -317,6 +317,11 @@ or bottom half).
>       the VM is trying to reclaim under GFP_NOFS conditions, hence this
>       method does not need to handle that situation itself.
>  
> +     Implementations must include conditional reschedule calls inside any
> +     scanning loop that is done. This allows the VFS to determine
> +     appropriate scan batch sizes without having to worry about whether
> +     implementations will cause holdoff problems due ot large batch sizes.

due to

Best regards,
Nicolas Kaiser

<Prev in Thread] Current Thread [Next in Thread>