xfs
[Top] [All Lists]

Re: [PATCH v2] xfstests: add support for ext4dev FSTYP

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH v2] xfstests: add support for ext4dev FSTYP
From: "Amir G." <amir73il@xxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 2 Jun 2011 10:16:48 +0300
Cc: xfs@xxxxxxxxxxx, sandeen@xxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, sergey57@xxxxxxxxx, Amir Goldstein <amir73il@xxxxxxxxxxxx>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=ndzUcD+J+Y063EdSku+q83J+cxevrK/zWStWkiBeVN4=; b=AtKRnm5+OWkaRxtyaq5McOLZEyt6MI8DemVE3zdss/kyIcpsRL6un1ft73F7LJOgQk Hm6D4jXTRIntXDOif5Dk+GlleJkVl9Q3fxcpIL5hHL/KdiS7Qx7Ry6+ngB8d4leYA3IJ +Pgk21atNhIX2aMqzC4m9yQcx+vKlINZ20WF4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=QbcZpeNebxKX4sc7dfbkrrx/Zi1B7veiANmjj+yN8WtsbLFlfVviSUvkIcG4BK29hy Vrke6tVNlTDuZRpdInsN9ymCLoC4YjXmc8AvxnNg4FcNs1U0O/IJYgUacd2DRRLylQ1a /3H8dAEXbJaF8LY/yGAPUzCmIpc+L4WHglCJI=
In-reply-to: <BANLkTimbPWfOJKq6er4mnSYNPcx6VHLcrw@xxxxxxxxxxxxxx>
References: <1306933012-8666-1-git-send-email-amir73il@xxxxxxxxxxxxxxxxxxxxx> <20110601232804.GL32466@dastard> <BANLkTi=sV5=PyZvNSd=DGNW-V84=27d7Yw@xxxxxxxxxxxxxx> <BANLkTimbPWfOJKq6er4mnSYNPcx6VHLcrw@xxxxxxxxxxxxxx>
Sender: amir73il@xxxxxxxxx
On Thu, Jun 2, 2011 at 5:33 AM, Amir G. <amir73il@xxxxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Jun 2, 2011 at 5:16 AM, Amir G. <amir73il@xxxxxxxxxxxxxxxxxxxxx> 
> wrote:
>> On Thu, Jun 2, 2011 at 2:28 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
>>> On Wed, Jun 01, 2011 at 03:56:52PM +0300, amir73il@xxxxxxxxxxxxxxxxxxxxx 
>>> wrote:
>>>> From: Amir Goldstein <amir73il@xxxxxxxxxxxx>
>>>>
>>>> From: Amir Goldstein <amir73il@xxxxxxxxxxxx>
>>>>
>>>> blkid knows to identify the ext4dev FSTYP of a partition that was
>>>> formatted with mkfs.ext4dev.
>>>> quota tools and various util-linux utils are also aware of ext4dev,
>>>> so ext4dev shares the same capabilities as ext4.
>>>>
>>>> Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxxxxx>
>>>> Tested-by: Sergey Ivanov <sergey57@xxxxxxxxx>
>>>> ---
>>>> ext4dev is used to test experimental ext4 code in mutual existance
>>>> with production ext4 code on the same system.
>>>>
>>>> Specifically, ext4 snapshots code is available for testing as a
>>>> stand-alone ext4dev module for Fedora 15 and Ubuntu 11.4
>>>> (see http://next3.sf.net).
>>>>
>>>> v1 -> v2:
>>>> - undo change of fsck -t $FSTYP to fsck.$FSTYP
>>>>
>>>>  common.defrag |    2 +-
>>>>  common.quota  |    4 ++--
>>>>  common.rc     |   10 +++++-----
>>>>  3 files changed, 8 insertions(+), 8 deletions(-)
>>>>
>>>> diff --git a/common.defrag b/common.defrag
>>>> index 1bcf01d..4850803 100644
>>>> --- a/common.defrag
>>>> +++ b/common.defrag
>>>> @@ -26,7 +26,7 @@ _require_defrag()
>>>>      xfs)
>>>>          DEFRAG_PROG=/usr/sbin/xfs_fsr
>>>>       ;;
>>>> -    ext4)
>>>> +    ext4|ext4dev)
>>>>          DEFRAG_PROG=/usr/bin/e4defrag
>>>>       ;;
>>>>      *)
>>>> diff --git a/common.quota b/common.quota
>>>> index 3c87ce1..b6d5f16 100644
>>>> --- a/common.quota
>>>> +++ b/common.quota
>>>> @@ -29,7 +29,7 @@ _require_quota()
>>>>      [ -n $QUOTA_PROG ] || _notrun "Quota user tools not installed"
>>>>
>>>>      case $FSTYP in
>>>> -    ext2|ext3|ext4|reiserfs)
>>>> +    ext2|ext3|ext4|ext4dev|reiserfs)
>>>>       if [ ! -d /proc/sys/fs/quota ]; then
>>>>           _notrun "Installed kernel does not support quotas"
>>>>       fi
>>>> @@ -237,7 +237,7 @@ _check_quota_usage()
>>>>       # Sync to get delalloc to disk
>>>>       sync
>>>>       VFS_QUOTA=0
>>>> -     if [ $FSTYP = "ext2" -o $FSTYP = "ext3" -o $FSTYP = "ext4" -o $FSTYP 
>>>> = "reiserfs" ]; then
>>>> +     if [ $FSTYP = "ext2" -o $FSTYP = "ext3" -o $FSTYP = "ext4" -o $FSTYP 
>>>> = "ext4dev" -o $FSTYP = "reiserfs" ]; then
>>>>               VFS_QUOTA=1
>>>>               quotaon -f -u -g $SCRATCH_MNT 2>/dev/null
>>>>       fi
>>>
>>> Perhaps this should be changes to a case statement?
>>>
>>
>> you're making me go to v3 in such a trivial patch, but ok, I'll do it ;-)
>>
>
> I rechecked the fsck -t ext4dev vs. fsck.ext4dev.
> fsck -t ext4dev doesn't work for me :-(
> Sergey has a newer version of  util-linux-ng
> see:
>
> amir@qalab:~/xfstests$ sudo fsck -t ext4dev -nf /dev/sda5
> fsck from util-linux-ng 2.17.2
> e2fsck 1.41.14 (22-Dec-2010)
> /dev/sda5 has unsupported feature(s): FEATURE_C7 FEATURE_C8 FEATURE_R7
> e2fsck: Get a newer version of e2fsck!

OK, after upgrading to newer util-linux and building it from git,
which also didn't help, I finally found who to blame - me.
I had an old (noauto) entry in /etc/fstab which claimed that /dev/sda5 is ext4.
fsck was picking up that entry and insisting that /dev/sda5 is ext4
(regardless of what it really is)
blkid isn't doing that silly thing.

Amir

<Prev in Thread] Current Thread [Next in Thread>