[Top] [All Lists]

Re: [PATCH] xfstests: add support for ext4dev FSTYP

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: add support for ext4dev FSTYP
From: "Ted Ts'o" <tytso@xxxxxxx>
Date: Wed, 1 Jun 2011 21:47:04 -0400
Cc: Amir Goldstein <amir73il@xxxxxxxxx>, XFS <xfs@xxxxxxxxxxx>, Sergey Ivanov <sergey57@xxxxxxxxx>, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>
In-reply-to: <4DE5C1FE.8080006@xxxxxxxxxx>
References: <BANLkTimBnAgiXZnvS56eAzEdJ=kw1zVGsg@xxxxxxxxxxxxxx> <4DE5C1FE.8080006@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, May 31, 2011 at 11:37:18PM -0500, Eric Sandeen wrote:
> I'm less certain of the change from fsck -t $FSTYP to fsck.$FSTYP
> What issue are you avoiding?  wouldn't fsck -t ext4dev invoke
> fsck.ext4dev anyway?

This is a change I make locally when I've been debugging my bigalloc
code as well.  There reason for that is because I want to override the
fsck.ext4 that would get used by using path hacking.  The problem was
that fsck -t ext4 will look for /sbin/fsck.ext4, where as I wanted it
to use the fsck.ext4 that was first in the PATH.

So I changed "/sbin/fsck -t $FSTYP" to "fsck.$FSTYP" and made sure
/sbin was tacked onto the path. 

It might be that the right answer is that fsck should have an
environment variable or some other way of controlling the search path
it uses to find the fsck.XXX binary.

                                                - Ted

<Prev in Thread] Current Thread [Next in Thread>