xfs
[Top] [All Lists]

Re: [PATCH v2] xfstests: add support for ext4dev FSTYP

To: amir73il@xxxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH v2] xfstests: add support for ext4dev FSTYP
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 2 Jun 2011 09:28:04 +1000
Cc: xfs@xxxxxxxxxxx, sandeen@xxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, sergey57@xxxxxxxxx, Amir Goldstein <amir73il@xxxxxxxxxxxx>
In-reply-to: <1306933012-8666-1-git-send-email-amir73il@xxxxxxxxxxxxxxxxxxxxx>
References: <1306933012-8666-1-git-send-email-amir73il@xxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Jun 01, 2011 at 03:56:52PM +0300, amir73il@xxxxxxxxxxxxxxxxxxxxx wrote:
> From: Amir Goldstein <amir73il@xxxxxxxxxxxx>
> 
> From: Amir Goldstein <amir73il@xxxxxxxxxxxx>
> 
> blkid knows to identify the ext4dev FSTYP of a partition that was
> formatted with mkfs.ext4dev.
> quota tools and various util-linux utils are also aware of ext4dev,
> so ext4dev shares the same capabilities as ext4.
> 
> Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxxxxx>
> Tested-by: Sergey Ivanov <sergey57@xxxxxxxxx>
> ---
> ext4dev is used to test experimental ext4 code in mutual existance
> with production ext4 code on the same system.
> 
> Specifically, ext4 snapshots code is available for testing as a
> stand-alone ext4dev module for Fedora 15 and Ubuntu 11.4
> (see http://next3.sf.net).
> 
> v1 -> v2:
> - undo change of fsck -t $FSTYP to fsck.$FSTYP
> 
>  common.defrag |    2 +-
>  common.quota  |    4 ++--
>  common.rc     |   10 +++++-----
>  3 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/common.defrag b/common.defrag
> index 1bcf01d..4850803 100644
> --- a/common.defrag
> +++ b/common.defrag
> @@ -26,7 +26,7 @@ _require_defrag()
>      xfs)
>          DEFRAG_PROG=/usr/sbin/xfs_fsr
>       ;;
> -    ext4)
> +    ext4|ext4dev)
>          DEFRAG_PROG=/usr/bin/e4defrag
>       ;;
>      *)
> diff --git a/common.quota b/common.quota
> index 3c87ce1..b6d5f16 100644
> --- a/common.quota
> +++ b/common.quota
> @@ -29,7 +29,7 @@ _require_quota()
>      [ -n $QUOTA_PROG ] || _notrun "Quota user tools not installed"
>  
>      case $FSTYP in
> -    ext2|ext3|ext4|reiserfs)
> +    ext2|ext3|ext4|ext4dev|reiserfs)
>       if [ ! -d /proc/sys/fs/quota ]; then
>           _notrun "Installed kernel does not support quotas"
>       fi
> @@ -237,7 +237,7 @@ _check_quota_usage()
>       # Sync to get delalloc to disk
>       sync
>       VFS_QUOTA=0
> -     if [ $FSTYP = "ext2" -o $FSTYP = "ext3" -o $FSTYP = "ext4" -o $FSTYP = 
> "reiserfs" ]; then
> +     if [ $FSTYP = "ext2" -o $FSTYP = "ext3" -o $FSTYP = "ext4" -o $FSTYP = 
> "ext4dev" -o $FSTYP = "reiserfs" ]; then
>               VFS_QUOTA=1
>               quotaon -f -u -g $SCRATCH_MNT 2>/dev/null
>       fi

Perhaps this should be changes to a case statement?

Cheers,

Dave.

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>