[Top] [All Lists]

Re: [PATCH] xfstests: add support for ext4dev FSTYP

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH] xfstests: add support for ext4dev FSTYP
From: Amir Goldstein <amir73il@xxxxxxxxx>
Date: Wed, 1 Jun 2011 09:37:15 +0300
Cc: XFS <xfs@xxxxxxxxxxx>, Sergey Ivanov <sergey57@xxxxxxxxx>, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=liIKI9y6bp0gkrZgiIdQUUdviTZ6fxJEnLry8BtjEsA=; b=sg69Lo3GS1B+6LZWaubqN23rNI07PVKGjw21O30H3gfa3KqFeGDbG5LAfGNBhHnck/ 0+Zz34OwMYRo13hNu5Q3tX/76nNqvccTNpCldkfRuYsBwQucEBZMcwgd+fz03iVjzKqO pR/JiELMhJ4uT80vtMW97XDWkchYThD8aJKx0=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=BkT3pMjffCx9Fizy8T37399TJ0dMPTJEIHTXxRpRnscUNDqS0KZX/4dYMn/WPZw95F WgY1xoEDa+h6paTBJ3eq+dkOJXzjDbus4cXLpfNffonD/gK+cOhsbZu6rz08VLAYtahV 9CEQuWLiQYNr4JyzuWLyjyP3PxriUV8SBZkv4=
In-reply-to: <4DE5CF6C.4080707@xxxxxxxxxx>
References: <BANLkTimBnAgiXZnvS56eAzEdJ=kw1zVGsg@xxxxxxxxxxxxxx> <4DE5C1FE.8080006@xxxxxxxxxx> <BANLkTikfjitncM=zLpfTrfQkd8VfQAxbUA@xxxxxxxxxxxxxx> <4DE5CC8E.1090208@xxxxxxxxxx> <4DE5CF6C.4080707@xxxxxxxxxx>
On Wed, Jun 1, 2011 at 8:34 AM, Eric Sandeen <sandeen@xxxxxxxxxx> wrote:
> On 6/1/11 12:22 AM, Eric Sandeen wrote:
>> On 5/31/11 11:56 PM, Amir Goldstein wrote:
>>> On Wed, Jun 1, 2011 at 7:37 AM, Eric Sandeen <sandeen@xxxxxxxxxx> wrote:
>>>> On 5/31/11 10:13 PM, Amir Goldstein wrote:
>>>>> From: Amir Goldstein <amir73il@xxxxxxxxxxxx>
>>>>> blkid knows to identify the ext4dev FSTYP of a partition that was
>>>>> formatted with mkfs.ext4dev.
>>>>> quota tools and various util-linux utils are also aware of ext4dev,
>>>>> so ext4dev shares the same capabilities as ext4.
>>>>> While testing on Fedora 15, we encoutered a buggy fsck utility, which
>>>>> invokes fsck.ext4, even though it was called with -t ext4dev argument.
>>>>> In our setup fsck.ext4dev knows about new fs features that fsck.ext4
>>>>> doesn't know, so the generic_fs_check fails.
>>>>> Since we have no real use of the extra capabilities provided by fsck util,
>>>>> we decided to invoke fsck.$FSTYP directly to avoid this issue.
>>>> Adding ext4dev to every case seems harmless enough.  TBH I thought I had
>>>> it there already but I guess not.
>>>> I'm less certain of the change from fsck -t $FSTYP to fsck.$FSTYP
>>>> What issue are you avoiding?  wouldn't fsck -t ext4dev invoke fsck.ext4dev 
>>>> anyway?
>>>> It seems like it should be harmless, but I don't understand how it helps 
>>>> you.
>>> As I wrote in the patch description, the fsck utility in Fedora 15 invokes
>>> fsck.ext4 for some reason when calling fsck -t ext4dev.
>> Oh, right.
>>> this fails because fsck.ext4 doesn't know the snapshot feature.
>>> I didn't debug fsck utility for that. it seemed pointless.
>> Did you file a bug with Fedora?  I'd rather fix the root cause than work 
>> around it...
>> Feel free to cc: me on the bug.

No, I didn't file a bug.
In any case, it was Sergey, who tested and reported the problem on F15.

Would you agree to fix the problem in xfstests now, so that F15 users can
test ext4dev and fix the bug in fsck regardless?

> RHEL6 does the same; mkfs.ext4dev then fsck -t ext4dev invokes fsck.ext4; but 
> this
> is because blkid identifies it as ext4, not ext4dev, despite the test_fs flag 
> being set.
> ISTR this is due to some tortured logic about when ext4dev isn't ext4dev, but
> I don't remember the details... I don't know if this is the same situation
> you're seeing; just to double check - does blkid correctly identify it as 
> ext4dev
> on F15?

For me (on Ubuntu) blkid identifies ext4dev, but maybe the tortured logic
finds unknown features a justification for declaring ext4dev?
Segrey, can you answer the question for F15?
Did you set FSTYP to ext4dev manually or did blkid identified it for you?

> -Eric
>> -Eric
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>