Re: [PATCH 1/2] xfs: clear inode per-lifetime state when recycling it

xfs

Re: [PATCH 1/2] xfs: clear inode per-lifetime state when recycling it

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 1/2] xfs: clear inode per-lifetime state when recycling it
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 31 May 2011 16:09:50 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1306815659-23346-2-git-send-email-david@xxxxxxxxxxxxx>
References:	<1306815659-23346-1-git-send-email-david@xxxxxxxxxxxxx> <1306815659-23346-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

Looks good.


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

> +              * XXX(dgc): should the XFS_ISTALE flag only be cleared here?

I think so.  Right now any iget on a stale inode will clear it, which
is very wrong.  Care to send a separate patch for that?

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 0/2] xfs: couple of fixes for 3.0-rc2, Dave Chinner [PATCH 1/2] xfs: clear inode per-lifetime state when recycling it, Dave Chinner Re: [PATCH 1/2] xfs: clear inode per-lifetime state when recycling it, Christoph Hellwig <= Re: [PATCH 1/2] xfs: clear inode per-lifetime state when recycling it, Alex Elder [PATCH 2/2] xfs: prevent bogus assert when trying to remove non-existent attribute, Dave Chinner Re: [PATCH 2/2] xfs: prevent bogus assert when trying to remove non-existent attribute, Christoph Hellwig Re: [PATCH 2/2] xfs: prevent bogus assert when trying to remove non-existent attribute, Alex Elder

Previous by Date:	Re: [TRIVIAL PATCH next 13/15] fs: Convert vmalloc/memset to vzalloc, Alex Elder
Next by Date:	Re: [PATCH 2/2] xfs: prevent bogus assert when trying to remove non-existent attribute, Christoph Hellwig
Previous by Thread:	[PATCH 1/2] xfs: clear inode per-lifetime state when recycling it, Dave Chinner
Next by Thread:	Re: [PATCH 1/2] xfs: clear inode per-lifetime state when recycling it, Alex Elder
Indexes:	[Date] [Thread] [Top] [All Lists]