xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfs: clear inode per-lifetime state when recycling it

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfs: clear inode per-lifetime state when recycling it
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 31 May 2011 16:09:50 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1306815659-23346-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1306815659-23346-1-git-send-email-david@xxxxxxxxxxxxx> <1306815659-23346-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
Looks good.


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

> +              * XXX(dgc): should the XFS_ISTALE flag only be cleared here?

I think so.  Right now any iget on a stale inode will clear it, which
is very wrong.  Care to send a separate patch for that?

<Prev in Thread] Current Thread [Next in Thread>