xfs
[Top] [All Lists]

Re: [PATCH 2/4] xfs: remove the unused ilock_nowait codepath in writepag

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/4] xfs: remove the unused ilock_nowait codepath in writepage
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 24 May 2011 21:18:57 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110428130514.335250421@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110428125546.696493391@xxxxxxxxxxxxxxxxxxxxxx> <20110428130514.335250421@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Thu, 2011-04-28 at 08:55 -0400, Christoph Hellwig wrote:
> wbc->nonblocking is never set, so this whole code has been unreachable
> for a long time.  I'm also not sure it would make a lot of sense -
> we'd rather finish our writeout after a short wait for the ilock
> instead of cancelling the whole ioend.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

I'll continue tomorrow on the next one; it'll take a
bit more time to review.

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 2/4] xfs: remove the unused ilock_nowait codepath in writepage, Alex Elder <=