[Top] [All Lists]

Re: [PATCH 2/9 v2] xfs: remove if_lastex

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/9 v2] xfs: remove if_lastex
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 24 May 2011 20:14:27 -0500
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20110523085253.GA15985@xxxxxxxxxxxxx>
References: <20110511150402.258164661@xxxxxxxxxxxxxxxxxxxxxx> <20110511150711.549194744@xxxxxxxxxxxxxxxxxxxxxx> <20110523085253.GA15985@xxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Mon, 2011-05-23 at 04:52 -0400, Christoph Hellwig wrote:
> The if_lastex field in struct xfs_ifork is only used as a temporary index
> during xfs_bmapi and xfs_bunmapi.  Instead of using the inode fork to store
> it keep it local in the callchain.  Fortunately this is very easy as
> we already pass a stack copy of it down the whole chain which can simplify
> be changed to be passed by reference.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>