xfs
[Top] [All Lists]

Re: [PATCH v2] xfstests:Make 225 compare map and fiemap at each block.

To: Yongqiang Yang <xiaoqiangnk@xxxxxxxxx>
Subject: Re: [PATCH v2] xfstests:Make 225 compare map and fiemap at each block.
From: Josef Bacik <josef@xxxxxxxxxx>
Date: Thu, 19 May 2011 14:19:16 -0400
Cc: josef@xxxxxxxxxx, sandeen@xxxxxxxxxx, xfs@xxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx
In-reply-to: <1305789665-32743-1-git-send-email-xiaoqiangnk@xxxxxxxxx>
References: <1305789665-32743-1-git-send-email-xiaoqiangnk@xxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, May 19, 2011 at 03:21:05PM +0800, Yongqiang Yang wrote:
> Due to my carelessness, I induced a ugly patch to ext4's fiemap, but
> 225 could not find it.  So I looked into the 225 and could not figure out
> logic in compare_map_and_fiemap(), which seemed to mix extents with
> blocks.  Then I made 225 compare map and fiemap at each block, the new
> 225 can find another bug in ext4 with 1k block.
> 
> The new 225 works well on ext3, ext4 and xfs with both 1K and 4K block.
> 
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@xxxxxxxxx>

Reviewed-by: Josef Bacik <josef@xxxxxxxxxx>

Thanks,

Josef

<Prev in Thread] Current Thread [Next in Thread>