xfs
[Top] [All Lists]

Re: [XFS Tests Punch Hole 2/3 v3] XFS TESTS: Add Fallocate Punch Hole Te

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [XFS Tests Punch Hole 2/3 v3] XFS TESTS: Add Fallocate Punch Hole Test Routines
From: Joel Becker <jlbec@xxxxxxxxxxxx>
Date: Wed, 18 May 2011 18:41:51 -0700
Cc: Allison Henderson <achender@xxxxxxxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>
In-reply-to: <20110519013144.GF32466@dastard>
Mail-followup-to: Dave Chinner <david@xxxxxxxxxxxxx>, Allison Henderson <achender@xxxxxxxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>
References: <4DD43300.6010908@xxxxxxxxxxxxxxxxxx> <20110519013144.GF32466@dastard>
Sender: Joel Becker <jlbec@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Thu, May 19, 2011 at 11:31:44AM +1000, Dave Chinner wrote:
> > +#
> > +# This test is successful when the following conditions are met:
> > +#  - ls shows that the number of blocks occupied by the file
> > +#    has decreased by the number of blocks punched out.
> 
> There's no guarantee that a filesystem will punch the number of
> blocks you expect.

        Cluster allocated filesystems like ocfs2 are certainly going to
punch some multiple of clusters, not exact blocks.  Eg if the hole is
punched in the middle of a cluster.

Joel

-- 

Life's Little Instruction Book #464

        "Don't miss the magic of the moment by focusing on what's
         to come."

                        http://www.jlbec.org/
                        jlbec@xxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>