[Top] [All Lists]

Re: [PATCH] xfs: fix duplicate workqueue initialisation

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix duplicate workqueue initialisation
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 10 May 2011 09:43:27 -0500
Cc: <xfs@xxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>
In-reply-to: <20110510053319.GA3047@xxxxxxxxxxxxx>
References: <1304993150-15327-1-git-send-email-david@xxxxxxxxxxxxx> <20110510053319.GA3047@xxxxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Tue, 2011-05-10 at 01:33 -0400, Christoph Hellwig wrote:
> On Tue, May 10, 2011 at 12:05:50PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > The workqueue initialisation function is called twice when
> > initialising the XFS subsystem. Remove the second initialisation
> > call.
> Not sure how we got there, but it looks indeed buggy.  I'm kinda
> surprised the workqueue code didn't blow up with the duplicate names.

Maybe duplicated by a merge along the way?

The second set of workqueues prevails, leaving the originals
unused and leaked.  In fact, an xfs module can probably even
unload cleanly because it doesn't really "own" the workqueue,
which by itself is an interesting artifact.

This is clearly a bug but I don't think it is truly harmful,
so I am not going to send it to Linus for 2.6.39.  If you
disagree, let me know and I'll send it separately.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>