xfs
[Top] [All Lists]

Re: [PATCH 2/5] xfs: exit AIL push work correctly when AIL is empty

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/5] xfs: exit AIL push work correctly when AIL is empty
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 9 May 2011 10:08:12 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1304650448-28438-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1304650448-28438-1-git-send-email-david@xxxxxxxxxxxxx> <1304650448-28438-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, May 06, 2011 at 12:54:05PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> The recent conversion of the xfsaild functionality to a work queue
> introduced a hard-to-hit log space grant hang. The main cause is a
> regression where a work exit path fails to clear the PUSHING state
> and recheck the target correctly.
> 
> Make both exit paths do the same PUSHING bit clearing and target
> checking when the "no more work to be done" condition is hit.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>