xfs
[Top] [All Lists]

Re: [PATCH] xfs: kill off xfs_printk()

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: kill off xfs_printk()
From: Alex Elder <aelder@xxxxxxx>
Date: Wed, 4 May 2011 09:29:58 -0500
Cc: <xfs@xxxxxxxxxxx>, Joe Perches <joe@xxxxxxxxxxx>
In-reply-to: <20110504004453.GC9114@dastard>
References: <a7077b2b2f6f46ac48d03cff4ccede2feba18f07.1304453673.git.aelder@xxxxxxx> <20110504004453.GC9114@dastard>
Reply-to: <aelder@xxxxxxx>
On Wed, 2011-05-04 at 10:44 +1000, Dave Chinner wrote:
> On Tue, May 03, 2011 at 03:14:44PM -0500, Alex Elder wrote:
> > From: Joe Perches <joe@xxxxxxxxxxx>
> > 
> > xfs_alert_tag() can be defined using xfs_alert(), and thereby avoid
> > using xfs_printk() altogether.  This is the only remaining use of
> > xfs_printk(), so changing it this way means xfs_printk() can simply
> > be eliminated.can simply be eliminated.can simply be eliminated.can
> > simply be eliminated.can simply be eliminated.can simply be
> > eliminated.can simply be eliminated.can simply be eliminated.can
> > simply be eliminated.
> > 
> > Also add format checking to the non-debug inline function xfs_debug.
> > Miscellaneous function prototype argument alignment.
> > 
> > (Updated to delete the definition of xfs_printk(), which is
> > no longer used or needed.)
> > 
> > Signed-off-by: Alex Elder <aelder@xxxxxxx>
> 
> If you are going to credit Joe as the original source of the patch
> in the commit (i.e. via the "From:" tag), you probably should copy
> in his original Signed-off-by tag as well....

Honestly I wasn't sure about that.  Since I changed it I
kind of hoped he'd acknowledge or sign off on it.  I guess
I'm still learning about the conventions for signing off
on things.  I want to give all credit properly, I just
don't always know the Right Way to do so.

                                        -Alex


<Prev in Thread] Current Thread [Next in Thread>