xfs
[Top] [All Lists]

Re: [PATCH] xfs: kill off xfs_printk()

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH] xfs: kill off xfs_printk()
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 4 May 2011 10:44:54 +1000
Cc: xfs@xxxxxxxxxxx, Joe Perches <joe@xxxxxxxxxxx>
In-reply-to: <a7077b2b2f6f46ac48d03cff4ccede2feba18f07.1304453673.git.aelder@xxxxxxx>
References: <a7077b2b2f6f46ac48d03cff4ccede2feba18f07.1304453673.git.aelder@xxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, May 03, 2011 at 03:14:44PM -0500, Alex Elder wrote:
> From: Joe Perches <joe@xxxxxxxxxxx>
> 
> xfs_alert_tag() can be defined using xfs_alert(), and thereby avoid
> using xfs_printk() altogether.  This is the only remaining use of
> xfs_printk(), so changing it this way means xfs_printk() can simply
> be eliminated.can simply be eliminated.can simply be eliminated.can
> simply be eliminated.can simply be eliminated.can simply be
> eliminated.can simply be eliminated.can simply be eliminated.can
> simply be eliminated.
> 
> Also add format checking to the non-debug inline function xfs_debug.
> Miscellaneous function prototype argument alignment.
> 
> (Updated to delete the definition of xfs_printk(), which is
> no longer used or needed.)
> 
> Signed-off-by: Alex Elder <aelder@xxxxxxx>

If you are going to credit Joe as the original source of the patch
in the commit (i.e. via the "From:" tag), you probably should copy
in his original Signed-off-by tag as well....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>