xfs
[Top] [All Lists]

Re: [PATCH] xfstests: clean up fallocate configuration tests

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: clean up fallocate configuration tests
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 3 May 2011 12:38:43 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>, Allison Henderson <achender@xxxxxxxxxxxxxxxxxx>
In-reply-to: <4DBF492E.3040400@xxxxxxxxxxx>
References: <4DBF492E.3040400@xxxxxxxxxxx>
Reply-to: <aelder@xxxxxxx>
On Mon, 2011-05-02 at 19:15 -0500, Eric Sandeen wrote:
> When I added fallocate support to fsx I inadvertently added
> a duplicate fallocate test.
> 
> Consolidate them both into one test (the link test, not the
> compile test) and make all tests use "true" rather than "yes"
> to be more consistent with other tests.

Looks reasonable to me.  I learned a little something
about autoconf while looking at this.  Glad you're an
expert :)

I do see that AC_TRY_COMPILE() is now considered obsolete
so at some point maybe we should update to use the suggested
alternatives (AC_COMPILE_IFELSE() in this example).

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>