[Top] [All Lists]

Re: [PATCH 1/4] xfs: optimize AGFL refills

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/4] xfs: optimize AGFL refills
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 29 Apr 2011 10:41:53 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110424190656.644950888@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110424190613.404786382@xxxxxxxxxxxxxxxxxxxxxx> <20110424190656.644950888@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Sun, Apr 24, 2011 at 03:06:14PM -0400, Christoph Hellwig wrote:
> While we need to make sure we do not reuse busy extents, there is no need
> to force out busy extents when moving them between the AGFL and the
> freespace btree as we still take care of that when doing the real allocation.
> To avoid the log force when just moving extents from the different free
> space tracking structures, move the busy search out of
> xfs_alloc_get_freelist into the callers that need it, and move the busy
> list insert from xfs_free_ag_extent which is used both by AGFL refills
> and real allocation to xfs_free_extent, which is only used by the latter.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Alex Elder <aelder@xxxxxxx>

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>